[SPARK-15754] [yarn] Not letting the credentials containing hdfs delegation tokens to be added in current user credential. #13499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kens to be added in current user credential.
Contributor
|
ok to test |
|
Test build #59938 has finished for PR 13499 at commit
|
Contributor
|
@subrotosanyal could you update the title to follow the convention? |
subrotosanyal
changed the title
Author
|
@vanzin |
Contributor
|
BTW the change looks fine, I just want to take a look at the rest of the code (the parts you're not touching) and also run some tests internally with kerberos enabled. |
|
|
||
| import org.apache.spark.{SparkContext, SparkException} | ||
| import org.apache.spark.deploy.yarn.{Client, ClientArguments, YarnSparkHadoopUtil} | ||
| import org.apache.spark.SparkContext |
Contributor
There was a problem hiding this comment.
These changes are unnecessary, and in fact we prefer the previous style.
|
Test build #59955 has finished for PR 13499 at commit
|
Author
|
hi @vanzin |
|
Test build #59958 has finished for PR 13499 at commit
|
Contributor
|
Ran some kerberos tests here and all looks good, so I'm merging this (will also try 1.6.x if there are no conflicts). Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2016
…ation tokens to be added in current user credential. ## What changes were proposed in this pull request? The credentials are not added to the credentials of UserGroupInformation.getCurrentUser(). Further if the client has possibility to login using keytab then the updateDelegationToken thread is not started on client. ## How was this patch tested? ran dev/run-tests Author: Subroto Sanyal <[email protected]> Closes #13499 from subrotosanyal/SPARK-15754-save-ugi-from-changing. (cherry picked from commit 61d729a) Signed-off-by: Marcelo Vanzin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2016
…ation tokens to be added in current user credential. ## What changes were proposed in this pull request? The credentials are not added to the credentials of UserGroupInformation.getCurrentUser(). Further if the client has possibility to login using keytab then the updateDelegationToken thread is not started on client. ## How was this patch tested? ran dev/run-tests Author: Subroto Sanyal <[email protected]> Closes #13499 from subrotosanyal/SPARK-15754-save-ugi-from-changing. (cherry picked from commit 61d729a) Signed-off-by: Marcelo Vanzin <[email protected]>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 6, 2016
…ation tokens to be added in current user credential. ## What changes were proposed in this pull request? The credentials are not added to the credentials of UserGroupInformation.getCurrentUser(). Further if the client has possibility to login using keytab then the updateDelegationToken thread is not started on client. ## How was this patch tested? ran dev/run-tests Author: Subroto Sanyal <[email protected]> Closes apache#13499 from subrotosanyal/SPARK-15754-save-ugi-from-changing. (cherry picked from commit 61d729a) Signed-off-by: Marcelo Vanzin <[email protected]> (cherry picked from commit a0cf7d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The credentials are not added to the credentials of UserGroupInformation.getCurrentUser(). Further if the client has possibility to login using keytab then the updateDelegationToken thread is not started on client.
How was this patch tested?
ran dev/run-tests