Skip to content

[SPARK-15642][SQL] Bug report: metadata gets lost when selecting a field of a StructType #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-15642][SQL] Bug report: metadata gets lost when selecting a field of a StructType #13467

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acb4b06
[SPARK-15642][SQL] Added test case
zommerfelds Jun 2, 2016
e745c48
[SPARK-15642][SQL] Moved test to more appropriate file
zommerfelds Jun 2, 2016
72ae5db
Merge branch 'master' into spark-15642
zommerfelds Feb 11, 2017
1152690
fixed bad conflict resolution
zommerfelds Feb 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package org.apache.spark.sql
import org.apache.spark.sql.catalyst.DefinedByConstructorParams
import org.apache.spark.sql.functions._
import org.apache.spark.sql.test.SharedSQLContext
import org.apache.spark.sql.types.{MetadataBuilder, StringType, StructField, StructType}

/**
* A test suite to test DataFrame/SQL functionalities with complex types (i.e. array, struct, map).
Expand Down Expand Up @@ -60,6 +61,15 @@ class DataFrameComplexTypeSuite extends QueryTest with SharedSQLContext {
assert(nullIntRow == org.apache.spark.sql.Row(null))
}

test("SPARK-15642 extracting from struct preserves metadata") {
val metadata = new MetadataBuilder().putString("key", "value").build()

val df = spark.createDataFrame(sparkContext.parallelize(Seq(Row(Row("foo")))),
StructType(Seq(StructField("struct", StructType(
Seq(StructField("str", StringType, false, metadata)))))))
assert(df.select(df("struct")("str")).schema.fields(0).metadata === metadata)
}

test("SPARK-15285 Generated SpecificSafeProjection.apply method grows beyond 64KB") {
val ds100_5 = Seq(S100_5()).toDS()
ds100_5.rdd.count
Expand Down