[Minor] Fix Java Lint errors introduced by #13286 and 13280 #13464

techaddict · 2016-06-02T06:34:44Z

What changes were proposed in this pull request?

Fix Java Lint errors introduced by #13286 and #13280

remove unused imports
Add exception for Append and Complete in lint-java

How was this patch tested?

Existing tests

SparkQA · 2016-06-02T08:33:53Z

Test build #59833 has finished for PR 13464 at commit 09486b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

techaddict · 2016-06-02T09:20:14Z

cc: @tdas @srowen

SparkQA · 2016-06-02T12:08:54Z

Test build #59843 has finished for PR 13464 at commit 2eb12af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2016-06-02T16:03:56Z

Oh, shouldn't we just fix that method name? I don't see why it was named Append() CC @tdas?

dongjoon-hyun · 2016-06-02T17:37:44Z

dev/checkstyle.xml

        <module name="MethodName">
-            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
+            <!-- Exclude Append and Complete were added in SPARK-15517 -->
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$|Append|Complete"/>


Hi, @techaddict .
When you need to exclude something from the rules, please use dev/checkstyle-suppressions.xml instead of changing the rules.

andrewor14 · 2016-06-02T21:13:16Z

This is not the right fix. Please close this PR.

techaddict · 2016-06-03T00:39:34Z

@andrewor14 between making it lowercase(which was my first fix, 09486b1) or adding an
exception in check style suppression, please let me know what is the other way
here

On Friday 3 June 2016, andrewor14 [email protected] wrote:

This is not the right fix. Please close this PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13464 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABUJw7L7gVmt9GNG6MKKT-pD2FaEWhxuks5qH0eygaJpZM4IsPqi
.

andrewor14 · 2016-06-03T01:02:45Z

I believe it is intended to be upper case to match scala; it's just that for java it must be a method so that's failing the style. @srowen is there anyway to turn off the lint checks for a part of the code like scalastyle:off?

techaddict · 2016-06-03T01:06:43Z

@andrewor14 As @dongjoon-hyun has suggested simply added the file to dev/checkstyle-suppressions.xml should work

srowen · 2016-06-03T09:59:20Z

@andrewor14 ah OK if that was on purpose, this can just be suppressed.

techaddict · 2016-06-08T10:06:51Z

created a updated PR with couple of more java lint fixes #13559

## What changes were proposed in this pull request? revived #13464 Fix Java Lint errors introduced by #13286 and #13280 Before: ``` Using `mvn` from path: /Users/pichu/Project/spark/build/apache-maven-3.3.9/bin/mvn Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0 Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[340,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[341,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[342,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[343,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[41,28] (naming) MethodName: Method name 'Append' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[52,28] (naming) MethodName: Method name 'Complete' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[61,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.PrimitiveType. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[62,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.Type. ``` ## How was this patch tested? ran `dev/lint-java` locally Author: Sandeep Singh <[email protected]> Closes #13559 from techaddict/minor-3.

## What changes were proposed in this pull request? revived #13464 Fix Java Lint errors introduced by #13286 and #13280 Before: ``` Using `mvn` from path: /Users/pichu/Project/spark/build/apache-maven-3.3.9/bin/mvn Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0 Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[340,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[341,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[342,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[343,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[41,28] (naming) MethodName: Method name 'Append' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[52,28] (naming) MethodName: Method name 'Complete' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[61,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.PrimitiveType. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[62,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.Type. ``` ## How was this patch tested? ran `dev/lint-java` locally Author: Sandeep Singh <[email protected]> Closes #13559 from techaddict/minor-3. (cherry picked from commit f958c1c) Signed-off-by: Sean Owen <[email protected]>

## What changes were proposed in this pull request? revived apache#13464 Fix Java Lint errors introduced by apache#13286 and apache#13280 Before: ``` Using `mvn` from path: /Users/pichu/Project/spark/build/apache-maven-3.3.9/bin/mvn Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0 Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[340,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[341,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[342,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[343,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[41,28] (naming) MethodName: Method name 'Append' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[52,28] (naming) MethodName: Method name 'Complete' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[61,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.PrimitiveType. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[62,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.Type. ``` ## How was this patch tested? ran `dev/lint-java` locally Author: Sandeep Singh <[email protected]> Closes apache#13559 from techaddict/minor-3.

techaddict mentioned this pull request Jun 2, 2016

[SPARK-15517][SQL][STREAMING] Add support for complete output mode in Structure Streaming #13286

Closed

techaddict added 2 commits June 2, 2016 15:33

remove unused imports

40f952c

Add style check exception for Append and Complete

2eb12af

techaddict force-pushed the minor-2 branch from 09486b1 to 2eb12af Compare June 2, 2016 10:09

dongjoon-hyun reviewed Jun 2, 2016
View reviewed changes

techaddict closed this Jun 3, 2016

techaddict mentioned this pull request Jun 8, 2016

[Minor] Fix Java Lint errors introduced by #13286 and #13280 #13559

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Minor] Fix Java Lint errors introduced by #13286 and 13280 #13464

[Minor] Fix Java Lint errors introduced by #13286 and 13280 #13464

Uh oh!

techaddict commented Jun 2, 2016 •

edited

Loading

Uh oh!

SparkQA commented Jun 2, 2016

Uh oh!

techaddict commented Jun 2, 2016

Uh oh!

SparkQA commented Jun 2, 2016

Uh oh!

srowen commented Jun 2, 2016

Uh oh!

dongjoon-hyun Jun 2, 2016 •

edited

Loading

Uh oh!

andrewor14 commented Jun 2, 2016

Uh oh!

techaddict commented Jun 3, 2016 •

edited

Loading

Uh oh!

andrewor14 commented Jun 3, 2016

Uh oh!

techaddict commented Jun 3, 2016

Uh oh!

srowen commented Jun 3, 2016

Uh oh!

techaddict commented Jun 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Minor] Fix Java Lint errors introduced by #13286 and 13280 #13464

[Minor] Fix Java Lint errors introduced by #13286 and 13280 #13464

Uh oh!

Conversation

techaddict commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

SparkQA commented Jun 2, 2016

Uh oh!

techaddict commented Jun 2, 2016

Uh oh!

SparkQA commented Jun 2, 2016

Uh oh!

srowen commented Jun 2, 2016

Uh oh!

dongjoon-hyun Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Jun 2, 2016

Uh oh!

techaddict commented Jun 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewor14 commented Jun 3, 2016

Uh oh!

techaddict commented Jun 3, 2016

Uh oh!

srowen commented Jun 3, 2016

Uh oh!

techaddict commented Jun 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

techaddict commented Jun 2, 2016 •

edited

Loading

dongjoon-hyun Jun 2, 2016 •

edited

Loading

techaddict commented Jun 3, 2016 •

edited

Loading