SPARK-15723: Fixed local-timezone-brittle test where short-timezone form "EST" is …

[javabrett]

What changes were proposed in this pull request?

Stop using the abbreviated and ambiguous timezone "EST" in a test, since it is machine-local default timezone dependent, and fails in different timezones. Fixed SPARK-15723.

How was this patch tested?

Note that to reproduce this problem in any locale/timezone, you can modify the scalatest-maven-plugin argLine to add a timezone:

<argLine>-ea -Xmx3g -XX:MaxPermSize=${MaxPermGen} -XX:ReservedCodeCacheSize=${CodeCacheSize} -Duser.timezone="Australia/Sydney"</argLine>

and run

$ mvn test -DwildcardSuites=org.apache.spark.status.api.v1.SimpleDateParamSuite -Dtest=none. Equally this will fix it in an effected timezone:

<argLine>-ea -Xmx3g -XX:MaxPermSize=${MaxPermGen} -XX:ReservedCodeCacheSize=${CodeCacheSize} -Duser.timezone="America/New_York"</argLine>

To test the fix, apply the above change to pom.xml to set test TZ to Australia/Sydney, and confirm the test now passes.

[srowen]

That much seems reasonable, but should we also try to fix the TimeZone with which Spark does the parsing to begin with? it shouldn't really be up to the machine's environment.

[srowen]

Also have a look at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
The title should for example include SPARK-15723

[srowen]

Jenkins test this please

[SparkQA]

Test build #59849 has finished for PR 13462 at commit 7dfc17b.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

@javabrett have a look at my comment on the JIRA, what do you think? this might be more fix-able.

[srowen]

Merged to master/2.0/1.6. I admit I made an error above, in that I thought this test had passed the PR builder, but actually I was mixed up and it had not. However I verified locally and on the Amplab builds that this test does in fact pass, so, got away with it.