[SPARK-15528][SQL] Fix race condition in NumberConverter #13391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #59584 has finished for PR 13391 at commit
|
Member
|
CC @tarekauel It is certainly a problem if this code is called from several threads in one JVM. It's possible it was written this way because for whatever reason this will never happen. However that doesn't strike me as likely. LGTM |
Member
Author
|
@rxin @tarekauel Seems this bug is a kind of critical issues, so we need to fix for the v2.0 release, thought? |
Contributor
|
Yes this is definitely a problem worth fixing. We should probably also backport this into 1.6. |
asfgit
pushed a commit
that referenced
this pull request
May 31, 2016
## What changes were proposed in this pull request? A local variable in NumberConverter is wrongly shared between threads. This pr fixes the race condition. ## How was this patch tested? Manually checked. Author: Takeshi YAMAMURO <[email protected]> Closes #13391 from maropu/SPARK-15528. (cherry picked from commit 95db8a4) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.0/1.6 |
asfgit
pushed a commit
that referenced
this pull request
May 31, 2016
## What changes were proposed in this pull request? A local variable in NumberConverter is wrongly shared between threads. This pr fixes the race condition. ## How was this patch tested? Manually checked. Author: Takeshi YAMAMURO <[email protected]> Closes #13391 from maropu/SPARK-15528. (cherry picked from commit 95db8a4) Signed-off-by: Sean Owen <[email protected]>
Member
Author
|
thanks! |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 31, 2016
## What changes were proposed in this pull request? A local variable in NumberConverter is wrongly shared between threads. This pr fixes the race condition. ## How was this patch tested? Manually checked. Author: Takeshi YAMAMURO <[email protected]> Closes apache#13391 from maropu/SPARK-15528. (cherry picked from commit 95db8a4) Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit ea84b33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A local variable in NumberConverter is wrongly shared between threads.
This pr fixes the race condition.
How was this patch tested?
Manually checked.