-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[Spark-15129][R][DOC]R API changes in ML #13285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jkbradley @MLnick I have marked this WIP, as I want to get your thoughts on if you think the format looks ok. I can add examples to KMeans and SurvReg is the overall format looks fine. |
|
@GayathriMurali |
|
@yanboliang Thanks, thats a good idea. However, that would just include example code and not how the output of summary() looks like. It might be useful to include that |
|
I think it's not necessary to include summary output of all models in the user guide, we can only show summary of GLM as an example. You need to copy the summary from your own running output. |
c95ee2c to
969d23c
Compare
|
@yanboliang Can you please help review? |
docs/sparkr.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have rename these with functions to spark.glm, spark.naiveBayes, spark.kmeans, spark.survreg.
|
@GayathriMurali |
|
@yanboliang I have included ml.r using include-example, wouldn't that cover all the examples? |
b4e1d12 to
4e81a15
Compare
|
@GayathriMurali |
|
FYI #10219 |
|
@yanboliang |
examples/src/main/r/ml.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this line to L28, it's better we can include the annotation line spark.glm and glm which can help users to understand corresponding code.
|
@GayathriMurali I think what is there for |
a781b69 to
8e7c4fe
Compare
|
@yanboliang Please let me know if there is anything else I can do to get this merged. |
|
Test build #3078 has finished for PR 13285 at commit
|
|
@yanboliang Please let me know if there is anything else I can do to help get this merged.Thanks! |
docs/sparkr.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Organize better:
The examples below show how to build several models:
* GLM using the Gaussian and Binomial model families
* AFT survival regression model
* Naive Bayes model
* K-Means model
|
This looks good, though I had one small comment. Thanks for your patience! |
8e7c4fe to
e773d03
Compare
|
@jkbradley I fixed for the review comment. Please let me know if there is anything else. Thanks! |
|
Merged into master and branch-2.0. Saw some very minor issues. I make another pass and fix them in a follow-up PR. Thanks! |
## What changes were proposed in this pull request? Make user guide changes to SparkR documentation for all changes that happened in 2.0 to Machine Learning APIs Author: GayathriMurali <[email protected]> Closes #13285 from GayathriMurali/SPARK-15129. (cherry picked from commit af2a4b0) Signed-off-by: Xiangrui Meng <[email protected]>
What changes were proposed in this pull request?
Make user guide changes to SparkR documentation for all changes that happened in 2.0 to Machine Learning APIs