[SPARK-15417][SQL][Python] PySpark shell always uses in-memory catalog #13203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #58904 has finished for PR 13203 at commit
|
Contributor
Author
|
retest this please |
Contributor
|
@andrewor14 So the problem is that getOrCreate() is not aware of the configuration (which could be different from the existing one), should we show an warning on that? |
|
Test build #58906 has finished for PR 13203 at commit
|
Contributor
Author
|
@davies yes that was the issue. Do you mean a warning for |
Member
|
LGTM |
Contributor
Author
|
OK I'm merging this into master 2.0 thanks. |
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
## What changes were proposed in this pull request? There is no way to use the Hive catalog in `pyspark-shell`. This is because we used to create a `SparkContext` before calling `SparkSession.enableHiveSupport().getOrCreate()`, which just gets the existing `SparkContext` instead of creating a new one. As a result, `spark.sql.catalogImplementation` was never propagated. ## How was this patch tested? Manual. Author: Andrew Or <[email protected]> Closes #13203 from andrewor14/fix-pyspark-shell. (cherry picked from commit c32b1b1) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is no way to use the Hive catalog in
pyspark-shell. This is because we used to create aSparkContextbefore callingSparkSession.enableHiveSupport().getOrCreate(), which just gets the existingSparkContextinstead of creating a new one. As a result,spark.sql.catalogImplementationwas never propagated.How was this patch tested?
Manual.