[SPARK-15381][SQL] physical object operator should define reference correctly #13167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * The output of this operator is a single-field safe row containing the deserialized object. | ||
| */ | ||
| case class DeserializeToObject( | ||
| case class DeserializeToObjectExec( |
Contributor
Author
There was a problem hiding this comment.
not related, but to make the name consistent with other physical plans.
Contributor
Author
|
Test build #58770 has finished for PR 13167 at commit
|
Contributor
Author
|
retest this please |
|
Test build #58773 has finished for PR 13167 at commit
|
| case class SerializeFromObjectExec( | ||
| serializer: Seq[NamedExpression], | ||
| child: SparkPlan) extends UnaryExecNode with CodegenSupport { | ||
| child: SparkPlan) extends UnaryExecNode with ObjectConsumerExec with CodegenSupport { |
Contributor
There was a problem hiding this comment.
minor: ObjectConsumerExec already extend UnaryExecNode
Contributor
|
LGTM |
|
Test build #58836 has finished for PR 13167 at commit
|
Contributor
|
Merging this into master and 2.0, thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
…correctly ## What changes were proposed in this pull request? Whole Stage Codegen depends on `SparkPlan.reference` to do some optimization. For physical object operators, they should be consistent with their logical version and set the `reference` correctly. ## How was this patch tested? new test in DatasetSuite Author: Wenchen Fan <[email protected]> Closes #13167 from cloud-fan/bug. (cherry picked from commit 661c210) Signed-off-by: Davies Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Whole Stage Codegen depends on
SparkPlan.referenceto do some optimization. For physical object operators, they should be consistent with their logical version and set thereferencecorrectly.How was this patch tested?
new test in DatasetSuite