[DOC][MINOR] ml.feature Scala and Python API sync #13159
Conversation
|
Test build #58728 has finished for PR 13159 at commit
|
| /** | ||
| * :: Experimental :: | ||
| * Model fitted by [[PCA]]. | ||
| * Model fitted by [[PCA]]. Transforms vectors to a lower dimensional space. |
There was a problem hiding this comment.
(Trivial.. but maybe single space between * Model fitted by [[PCA]] and Transforms vectors to a lower dimensional space.)
There was a problem hiding this comment.
yeah you're right, I should have used single space. Thanks @HyukjinKwon !
|
Test build #58792 has finished for PR 13159 at commit
|
|
retest this please |
|
Test build #58795 has finished for PR 13159 at commit
|
|
Thanks for doing this, looks like a good improvement. While we are updating the PyDocs here it seems like some of stages that require fitting make links to the transformer/model when they say fitted by and some don't - we could consider fixing the links while we are here but its probably not all that bad to leave as is. |
|
Ya, that would be good to fix and might as well do it here |
| /** | ||
| * :: Experimental :: | ||
| * PCA trains a model to project vectors to a low-dimensional space using PCA. | ||
| * PCA trains a model to project vectors to a lower dimensional space of the top [[PCA!.k]] |
There was a problem hiding this comment.
while you're looking @holdenk , is this right with the "!"? I saw this somewhere else and without that it seems like it can't find k, but I couldn't find anything about it in scaladoc.
There was a problem hiding this comment.
Yah I took a look - it seems to generate the correct link and we use it elsewhere but it doesn't seem to really do much.
|
Test build #58812 has finished for PR 13159 at commit
|
|
LGTM, thanks @BryanCutler. Merged to master/branch-2.0 |
|
@MLnick did you actually merge this in 2.0? |
I reviewed Scala and Python APIs for ml.feature and corrected discrepancies. Built docs locally, ran style checks Author: Bryan Cutler <[email protected]> Closes #13159 from BryanCutler/ml.feature-api-sync. (cherry picked from commit b1bc5eb) Signed-off-by: Reynold Xin <[email protected]>
|
@rxin I thought I had but must have missed it by mistake. Thanks for picking to 2.0 |
6 participants
What changes were proposed in this pull request?
I reviewed Scala and Python APIs for ml.feature and corrected discrepancies.
How was this patch tested?
Built docs locally, ran style checks