[MINOR] Fix Typos #13078
Closed
[MINOR] Fix Typos #13078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58488 has started for PR 13078 at commit |
Contributor
|
i will retrigger this build once maintenance is over. |
Member
There was a problem hiding this comment.
Y'know, while we're at it, the matrix args in this whole class don't match the docs. The arg here and similarly elsewhere can be called "A" not "a".
Also this should check that A.rows == y.length for consistency.
Contributor
Author
There was a problem hiding this comment.
Right. I will rename the matrix args to upper and add this missing checking.
Contributor
|
jenkins, test this please |
1 similar comment
Contributor
|
jenkins, test this please |
|
Test build #58497 has finished for PR 13078 at commit
|
|
Test build #58537 has finished for PR 13078 at commit
|
Contributor
|
@srowen we should backport the doc fixes into branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
1,Rename matrix args in BreezeUtil to upper to match the doc 2,Fix several typos in ML and SQL manual tests Author: Zheng RuiFeng <[email protected]> Closes #13078 from zhengruifeng/fix_ann. (cherry picked from commit c7efc56) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1,Rename matrix args in BreezeUtil to upper to match the doc
2,Fix several typos in ML and SQL
How was this patch tested?
manual tests