Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented May 12, 2016

What changes were proposed in this pull request?

Add impurity param to GBTRegressor and mark the of the models & regressors in regression.py as experimental to match Scaladoc.

How was this patch tested?

Added default value to init, tested with unit/doc tests.

@holdenk holdenk changed the title [SPARK-15281][PySpark][ML][TRIVIAL] Add impurity param to GBTRegressor [SPARK-15281][PySpark][ML][TRIVIAL] Add impurity param to GBTRegressor & add experimental inside of regression.py May 12, 2016
@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58453 has finished for PR 13071 at commit 274400d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor

MLnick commented May 12, 2016

LGTM. Merged to master and branch-2.0

asfgit pushed a commit that referenced this pull request May 12, 2016
…r & add experimental inside of regression.py

## What changes were proposed in this pull request?

Add impurity param to  GBTRegressor and mark the of the models & regressors in regression.py as experimental to match Scaladoc.

## How was this patch tested?

Added default value to init, tested with unit/doc tests.

Author: Holden Karau <[email protected]>

Closes #13071 from holdenk/SPARK-15281-GBTRegressor-impurity.

(cherry picked from commit 5207a00)
Signed-off-by: Nick Pentreath <[email protected]>
@asfgit asfgit closed this in 5207a00 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants