Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR removes the old json(path: String) API which is covered by the new json(paths: String*).

How was this patch tested?

Jenkins tests (existing tests should cover this)

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58299 has finished for PR 13040 at commit 35db95f.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58300 has finished for PR 13040 at commit 7c8ee6d.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58303 has finished for PR 13040 at commit f9b123c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58304 has finished for PR 13040 at commit 5576054.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

(Sorry, I left a wrong comment referring unrelated PRs here and I removed that.)

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58313 has finished for PR 13040 at commit d28b24d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented May 11, 2016

cc @rxin

(I see doc tests and test in Python are still using SqlContext. Do you mind if I correct this for SparkSession in another PR?)

@rxin
Copy link
Contributor

rxin commented May 11, 2016

LGTM - merging in master/2.0.

@rxin
Copy link
Contributor

rxin commented May 11, 2016

Yes please submit another pr for those.

@asfgit asfgit closed this in 3ff0120 May 11, 2016
asfgit pushed a commit that referenced this pull request May 11, 2016
## What changes were proposed in this pull request?

This PR removes the old `json(path: String)` API which is covered by the new `json(paths: String*)`.

## How was this patch tested?

Jenkins tests (existing tests should cover this)

Author: hyukjinkwon <[email protected]>
Author: Hyukjin Kwon <[email protected]>

Closes #13040 from HyukjinKwon/SPARK-15250.

(cherry picked from commit 3ff0120)
Signed-off-by: Reynold Xin <[email protected]>
@tdas
Copy link
Contributor

tdas commented Jun 17, 2016

For future reference. Removing this method broke source compatibility in case as

Option(path).map(spark.read.json)  // does not compile, after this patch.

In this sort of shorthand of functions using 1 parameter, works only if the method signature has one parameter and does not work when the method has varargs.

@HyukjinKwon
Copy link
Member Author

@tdas Thanks, I will keep in mind.

@HyukjinKwon HyukjinKwon deleted the SPARK-15250 branch January 2, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants