-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-15250][SQL] Remove deprecated json API in DataFrameReader #13040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #58299 has finished for PR 13040 at commit
|
|
Test build #58300 has finished for PR 13040 at commit
|
|
Test build #58303 has finished for PR 13040 at commit
|
|
Test build #58304 has finished for PR 13040 at commit
|
|
(Sorry, I left a wrong comment referring unrelated PRs here and I removed that.) |
|
Test build #58313 has finished for PR 13040 at commit
|
|
cc @rxin (I see doc tests and test in Python are still using |
|
LGTM - merging in master/2.0. |
|
Yes please submit another pr for those. |
## What changes were proposed in this pull request? This PR removes the old `json(path: String)` API which is covered by the new `json(paths: String*)`. ## How was this patch tested? Jenkins tests (existing tests should cover this) Author: hyukjinkwon <[email protected]> Author: Hyukjin Kwon <[email protected]> Closes #13040 from HyukjinKwon/SPARK-15250. (cherry picked from commit 3ff0120) Signed-off-by: Reynold Xin <[email protected]>
|
For future reference. Removing this method broke source compatibility in case as In this sort of shorthand of functions using 1 parameter, works only if the method signature has one parameter and does not work when the method has varargs. |
|
@tdas Thanks, I will keep in mind. |
What changes were proposed in this pull request?
This PR removes the old
json(path: String)API which is covered by the newjson(paths: String*).How was this patch tested?
Jenkins tests (existing tests should cover this)