Skip to content

Conversation

@xwu0226
Copy link
Contributor

@xwu0226 xwu0226 commented May 8, 2016

What changes were proposed in this pull request?

Add new test cases for including distinct aggregate in having clause in 2.0 branch.
This is a followup PR for #12974, which is for 1.6 branch.

@hvanhovell
Copy link
Contributor

Ok to test

@SparkQA
Copy link

SparkQA commented May 8, 2016

Test build #2976 has finished for PR 12984 at commit 969e244.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xwu0226
Copy link
Contributor Author

xwu0226 commented May 20, 2016

@cloud-fan Please see if we should add these test cases to 2.0 branch. It is related to the distinct aggregate in having clause. Thanks!

@cloud-fan
Copy link
Contributor

retest this please

@cloud-fan
Copy link
Contributor

LGTM, pending jenkins

@SparkQA
Copy link

SparkQA commented May 20, 2016

Test build #58952 has finished for PR 12984 at commit 5445805.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xwu0226
Copy link
Contributor Author

xwu0226 commented May 20, 2016

@cloud-fan I rebased my local branch and pushed again.

@xwu0226
Copy link
Contributor Author

xwu0226 commented May 20, 2016

@cloud-fan Please help kickoff the retest please?

@dilipbiswal
Copy link
Contributor

retest this please

1 similar comment
@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented May 21, 2016

Test build #59071 has finished for PR 12984 at commit 9c184ba.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented May 21, 2016

Test build #59072 has finished for PR 12984 at commit 9c184ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master and 2.0!

@asfgit asfgit closed this in df9adb5 May 22, 2016
asfgit pushed a commit that referenced this pull request May 22, 2016
## What changes were proposed in this pull request?
Add new test cases for including distinct aggregate in having clause in 2.0 branch.
This is a followup PR for [#12974](#12974), which is for 1.6 branch.

Author: xin Wu <[email protected]>

Closes #12984 from xwu0226/SPARK-15206.

(cherry picked from commit df9adb5)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants