Skip to content

[MINOR][Build] Adds spark-warehouse/ to .gitignore #12929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MINOR][Build] Adds spark-warehouse/ to .gitignore #12929

wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented May 5, 2016

What changes were proposed in this pull request?

Adds spark-warehouse/ to .gitignore.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57876 has finished for PR 12929 at commit a2fd543.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented May 5, 2016

Not a big deal, but is this a build product? it should be in target/ if so, ideally. We've got a lot of files that get generated elsewhere in the tree

@liancheng
Copy link
Contributor Author

liancheng commented May 5, 2016 •
edited
Loading

@srowen TBH I also felt hesitated to put the [Build] tag in PR title. But I couldn't find a more suitable component for this one...

@liancheng
Copy link
Contributor Author

liancheng commented May 5, 2016 •
edited
Loading

BTW, spark-warehouse isn't some temporary folder generated during testing (which should go to target/), it's now the default warehouse location for holding production data, and, of course, is configurable.

@andrewor14
Copy link
Contributor

andrewor14 commented May 5, 2016 •
edited
Loading

LGTM merging into master 2.0. I've had to manually delete this myself many times.

asfgit pushed a commit that referenced this pull request May 5, 2016
@liancheng
[MINOR][BUILD] Adds spark-warehouse/ to .gitignore
b063d9b 
## What changes were proposed in this pull request?

Adds spark-warehouse/ to `.gitignore`.

## How was this patch tested?

N/A

Author: Cheng Lian <[email protected]>

Closes #12929 from liancheng/gitignore-spark-warehouse.

(cherry picked from commit 63db2bd)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 63db2bd May 5, 2016
@liancheng liancheng deleted the gitignore-spark-warehouse branch May 6, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng @SparkQA @srowen @andrewor14