[SPARK-15131][SQL] Shutdown StateStore management thread when SparkContext has been shutdown #12905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #57788 has finished for PR 12905 at commit
|
Member
|
retest this please |
2 similar comments
Member
|
retest this please |
Member
|
retest this please |
Member
|
Let's run more times to see if it's stable. |
|
Test build #57804 has finished for PR 12905 at commit
|
|
Test build #2970 has finished for PR 12905 at commit
|
Contributor
Author
|
Something flaky with Mima! |
|
Test build #2969 has finished for PR 12905 at commit
|
|
Test build #2971 has finished for PR 12905 at commit
|
|
Test build #2972 has finished for PR 12905 at commit
|
|
Test build #2973 has finished for PR 12905 at commit
|
Member
|
LGTM. Merging to master / 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 5, 2016
…ntext has been shutdown ## What changes were proposed in this pull request? Make sure that whenever the StateStoreCoordinator cannot be contacted, assume that the SparkContext and RpcEnv on the driver has been shutdown, and therefore stop the StateStore management thread, and unload all loaded stores. ## How was this patch tested? Updated unit tests. Author: Tathagata Das <[email protected]> Closes #12905 from tdas/SPARK-15131. (cherry picked from commit bde27b8) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make sure that whenever the StateStoreCoordinator cannot be contacted, assume that the SparkContext and RpcEnv on the driver has been shutdown, and therefore stop the StateStore management thread, and unload all loaded stores.
How was this patch tested?
Updated unit tests.