[SPARK-6005][Tests]Fix flaky test: o.a.s.streaming.kafka.DirectKafkaStreamSuite.offset recovery #12903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
changed the title
zsxwing
changed the title
Member
Author
|
cc @tdas |
|
Test build #57784 has finished for PR 12903 at commit
|
Contributor
|
LGTM. Test for flakiness by running multiple times. |
|
Test build #2979 has finished for PR 12903 at commit
|
|
Test build #2980 has finished for PR 12903 at commit
|
|
Test build #2981 has finished for PR 12903 at commit
|
|
Test build #2982 has finished for PR 12903 at commit
|
Member
Author
|
All tests passed. Merging to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 10, 2016
…StreamSuite.offset recovery ## What changes were proposed in this pull request? Because this test extracts data from `DStream.generatedRDDs` before stopping, it may get data before checkpointing. Then after recovering from the checkpoint, `recoveredOffsetRanges` may contain something not in `offsetRangesBeforeStop`, which will fail the test. Adding `Thread.sleep(1000)` before `ssc.stop()` will reproduce this failure. This PR just moves the logic of `offsetRangesBeforeStop` (also renamed to `offsetRangesAfterStop`) after `ssc.stop()` to fix the flaky test. ## How was this patch tested? Jenkins unit tests. Author: Shixiong Zhu <[email protected]> Closes #12903 from zsxwing/SPARK-6005. (cherry picked from commit 9533f53) Signed-off-by: Shixiong Zhu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2016
…StreamSuite.offset recovery ## What changes were proposed in this pull request? Because this test extracts data from `DStream.generatedRDDs` before stopping, it may get data before checkpointing. Then after recovering from the checkpoint, `recoveredOffsetRanges` may contain something not in `offsetRangesBeforeStop`, which will fail the test. Adding `Thread.sleep(1000)` before `ssc.stop()` will reproduce this failure. This PR just moves the logic of `offsetRangesBeforeStop` (also renamed to `offsetRangesAfterStop`) after `ssc.stop()` to fix the flaky test. ## How was this patch tested? Jenkins unit tests. Author: Shixiong Zhu <[email protected]> Closes #12903 from zsxwing/SPARK-6005. (cherry picked from commit 9533f53) Signed-off-by: Sean Owen <[email protected]>
Member
|
Also merged to 1.6 |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 23, 2016
…StreamSuite.offset recovery ## What changes were proposed in this pull request? Because this test extracts data from `DStream.generatedRDDs` before stopping, it may get data before checkpointing. Then after recovering from the checkpoint, `recoveredOffsetRanges` may contain something not in `offsetRangesBeforeStop`, which will fail the test. Adding `Thread.sleep(1000)` before `ssc.stop()` will reproduce this failure. This PR just moves the logic of `offsetRangesBeforeStop` (also renamed to `offsetRangesAfterStop`) after `ssc.stop()` to fix the flaky test. ## How was this patch tested? Jenkins unit tests. Author: Shixiong Zhu <[email protected]> Closes apache#12903 from zsxwing/SPARK-6005. (cherry picked from commit 9533f53) Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 4fdac3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Because this test extracts data from
DStream.generatedRDDsbefore stopping, it may get data before checkpointing. Then after recovering from the checkpoint,recoveredOffsetRangesmay contain something not inoffsetRangesBeforeStop, which will fail the test. AddingThread.sleep(1000)beforessc.stop()will reproduce this failure.This PR just moves the logic of
offsetRangesBeforeStop(also renamed tooffsetRangesAfterStop) afterssc.stop()to fix the flaky test.How was this patch tested?
Jenkins unit tests.