Skip to content

Conversation

@liningalex
Copy link
Contributor

What changes were proposed in this pull request?

We had the issue when using snowplow in our Spark applications. Snowplow requires json4s version 3.2.11 while Spark still use a few years old version 3.2.10. The change is to upgrade json4s jar to 3.2.11.

How was this patch tested?

We built Spark jar and successfully ran our applications in local and cluster modes.

@srowen
Copy link
Member

srowen commented May 4, 2016

I think this will fail because this doesn't update the dependencies file. It doesn't look like there are any incompatible changes, so this seems OK.

@srowen
Copy link
Member

srowen commented May 4, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57783 has finished for PR 12901 at commit 4f0124d.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liningalex
Copy link
Contributor Author

pushed the changes:

commit 23fb07f
Author: Lining Sun [email protected]
Date: Wed May 4 11:55:14 2016 -0700

[apache/spark] [SPARK-15123] upgrade org.json4s to 3.2.11 version

dev/deps/spark-deps-hadoop-2.2

On Wed, May 4, 2016 at 11:36 AM, Apache Spark QA [email protected]
wrote:

Test build #57783 has finished
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57783/consoleFull

for PR 12901 at commit 4f0124d
4f0124d
.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12901 (comment)

@srowen
Copy link
Member

srowen commented May 4, 2016

I can tell you you'll need to update all of the deps files, not just one. You also don't have to post a message about the commits.

@liningalex
Copy link
Contributor Author

should have pushed all deps files. thanks.

On Wed, May 4, 2016 at 11:59 AM, Sean Owen [email protected] wrote:

I can tell you you'll need to update all of the deps files, not just one.
You also don't have to post a message about the commits.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12901 (comment)

@srowen
Copy link
Member

srowen commented May 4, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57789 has finished for PR 12901 at commit e7899fd.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented May 4, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57792 has finished for PR 12901 at commit e7899fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 5, 2016
## What changes were proposed in this pull request?

We had the issue when using snowplow in our Spark applications. Snowplow requires json4s version 3.2.11 while Spark still use a few years old version 3.2.10. The change is to upgrade json4s jar to 3.2.11.

## How was this patch tested?

We built Spark jar and successfully ran our applications in local and cluster modes.

Author: Lining Sun <[email protected]>

Closes #12901 from liningalex/master.

(cherry picked from commit 592fc45)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented May 5, 2016

merged to master/2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants