[SPARK-15115][SQL] Reorganize whole stage codegen benchmark suites #12891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @davies |
| * | ||
| * Benchmarks in this file are skipped in normal builds. | ||
| */ | ||
| class SortBenchmark extends BenchmarkBase { |
Contributor
Author
There was a problem hiding this comment.
this was taken from RadixSortSuite
|
Test build #57738 has finished for PR 12891 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Thanks - merging in master/branch-2.0. The earlier test failure was unrelated. |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2016
## What changes were proposed in this pull request? We currently have a single suite that is very large, making it difficult to maintain and play with specific primitives. This patch reorganizes the file by creating multiple benchmark suites in a single package. Most of the changes are straightforward move of code. On top of the code moving, I did: 1. Use SparkSession instead of SQLContext. 2. Turned most benchmark scenarios into a their own test cases, rather than having multiple scenarios in a single test case, which takes forever to run. ## How was this patch tested? This is a test only change. Author: Reynold Xin <[email protected]> Closes #12891 from rxin/SPARK-15115. (cherry picked from commit 6274a52) Signed-off-by: Reynold Xin <[email protected]>
|
Test build #2968 has finished for PR 12891 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently have a single suite that is very large, making it difficult to maintain and play with specific primitives. This patch reorganizes the file by creating multiple benchmark suites in a single package.
Most of the changes are straightforward move of code. On top of the code moving, I did:
How was this patch tested?
This is a test only change.