[SPARK-15103][SQL] Refactored FileCatalog class to allow StreamFileCatalog to infer partitioning #12879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tdas
changed the title
|
|
||
| override def getStatus(path: Path): Array[FileStatus] = leafDirToChildrenFiles(path) | ||
|
|
||
| protected def inferPartitioning(): PartitionSpec = { |
Contributor
Author
There was a problem hiding this comment.
@marmbrus These methods are basically unchanged, just moved around from HDFSFileCatalog to PartitioningAwareFileCatalog.
Contributor
|
/cc @liancheng @cloud-fan |
|
Test build #57672 has finished for PR 12879 at commit
|
|
Test build #57674 has finished for PR 12879 at commit
|
| * A [[FileCatalog]] that generates the list of files to processing by reading them from the | ||
| * metadata log files generated by the [[FileStreamSink]]. | ||
| */ | ||
| class MetadataLogFileCatalog(sparkSession: SparkSession, path: Path) |
Contributor
Author
There was a problem hiding this comment.
This file is basically StreamFileCatalog.scala renamed. Github not showing it as a rename.
|
Test build #57690 has finished for PR 12879 at commit
|
|
Test build #57704 has finished for PR 12879 at commit
|
|
Test build #57706 has finished for PR 12879 at commit
|
Contributor
Author
|
ping @marmbrus |
Contributor
|
LGTM |
Contributor
Author
|
Thanks! Merging this to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2016
…talog to infer partitioning ## What changes were proposed in this pull request? File Stream Sink writes the list of written files in a metadata log. StreamFileCatalog reads the list of the files for processing. However StreamFileCatalog does not infer partitioning like HDFSFileCatalog. This PR enables that by refactoring HDFSFileCatalog to create an abstract class PartitioningAwareFileCatalog, that has all the functionality to infer partitions from a list of leaf files. - HDFSFileCatalog has been renamed to ListingFileCatalog and it extends PartitioningAwareFileCatalog by providing a list of leaf files from recursive directory scanning. - StreamFileCatalog has been renamed to MetadataLogFileCatalog and it extends PartitioningAwareFileCatalog by providing a list of leaf files from the metadata log. - The above two classes has been moved into their own files as they are not interfaces that should be in fileSourceInterfaces.scala. ## How was this patch tested? - FileStreamSinkSuite was update to see if partitioning gets inferred, and on reading whether the partitions get pruned correctly based on the query. - Other unit tests are unchanged and pass as expected. Author: Tathagata Das <[email protected]> Closes #12879 from tdas/SPARK-15103. (cherry picked from commit 0fd3a47) Signed-off-by: Tathagata Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
File Stream Sink writes the list of written files in a metadata log. StreamFileCatalog reads the list of the files for processing. However StreamFileCatalog does not infer partitioning like HDFSFileCatalog.
This PR enables that by refactoring HDFSFileCatalog to create an abstract class PartitioningAwareFileCatalog, that has all the functionality to infer partitions from a list of leaf files.
How was this patch tested?