[SPARK-14050] [ML] Add multiple languages support and additional methods for Stop Words Remover #12843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating English stop words list, "d" is a stop word.
|
Test build #57535 has finished for PR 12843 at commit
|
|
Test build #57536 has finished for PR 12843 at commit
|
| */ | ||
| val caseSensitive: BooleanParam = new BooleanParam(this, "caseSensitive", | ||
| "whether to do case-sensitive comparison during filtering") | ||
| "whether to do a case-sensitive comparison over the stop stop words") |
Member
|
Should there be a unit tests which iterates through StopWordsRemover.supportedLanguages and tests loading all & checking they are non-empty? Other than those small items, this looks good to me |
|
Test build #57769 has finished for PR 12843 at commit
|
Member
|
LGTM pending tests |
|
Test build #2974 has finished for PR 12843 at commit
|
|
Test build #57923 has finished for PR 12843 at commit
|
Contributor
Author
|
Merged into master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2016
…ds for Stop Words Remover ## What changes were proposed in this pull request? This PR continues the work from #11871 with the following changes: * load English stopwords as default * covert stopwords to list in Python * update some tests and doc ## How was this patch tested? Unit tests. Closes #11871 cc: burakkose srowen Author: Burak Köse <[email protected]> Author: Xiangrui Meng <[email protected]> Author: Burak KOSE <[email protected]> Closes #12843 from mengxr/SPARK-14050. (cherry picked from commit e20cd9f) Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR continues the work from #11871 with the following changes:
How was this patch tested?
Unit tests.
Closes #11871
cc: @burakkose @srowen