[SPARK-14391][launcher] Fix launcher communication test, take 2. #12785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's actually a race here: the state of the handler was changed before the connection is set, so the test code could be notified of the state change, wake up, and still see the connection as null, triggering the assert.
|
Test build #57357 has finished for PR 12785 at commit
|
Contributor
Author
|
one more time... retest this please. |
|
Test build #57375 has finished for PR 12785 at commit
|
Contributor
Author
|
and one more. retest this please |
|
Test build #57385 has finished for PR 12785 at commit
|
Contributor
|
Merging in master. |
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2016
There's actually a race here: the state of the handler was changed before the connection was set, so the test code could be notified of the state change, wake up, and still see the connection as null, triggering the assert. Author: Marcelo Vanzin <[email protected]> Closes #12785 from vanzin/SPARK-14391. (cherry picked from commit 73c20bf)
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 21, 2016
There's actually a race here: the state of the handler was changed before the connection was set, so the test code could be notified of the state change, wake up, and still see the connection as null, triggering the assert. Author: Marcelo Vanzin <[email protected]> Closes apache#12785 from vanzin/SPARK-14391. (cherry picked from commit 73c20bf) (cherry picked from commit 16b7f1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's actually a race here: the state of the handler was changed before
the connection was set, so the test code could be notified of the state
change, wake up, and still see the connection as null, triggering the assert.