[SPARK-14990][SQL] nvl, coalesce, array with parameter of type 'array' #12768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
(@dosoft I think it would be great if the PR description is filled up.) |
Member
There was a problem hiding this comment.
A space between ){. This will not pass Scala style test, +(See, scalastyle-config.xml#L230-L235).
if (!t.sameType(types.head)) {
Member
There was a problem hiding this comment.
(FYI, if you run ./dev/run_tests (this triggers style checking first) or ./build/sbt scalastyle before submitting commits, this will shows up the comments I left)
rxin
added a commit
to rxin/spark
that referenced
this pull request
May 20, 2016
[SPARK-14990][SQL] nvl, coalesce, array with parameter of type 'array'
Contributor
|
FYI I created #13208 It fixed a bug in this code and added a test case. |
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
## What changes were proposed in this pull request? This patch fixes a bug in TypeUtils.checkForSameTypeInputExpr. Previously the code was testing on strict equality, which does not taking nullability into account. This is based on #12768. This patch fixed a bug there (with empty expression) and added a test case. ## How was this patch tested? Added a new test suite and test case. Closes #12768. Author: Reynold Xin <[email protected]> Author: Oleg Danilov <[email protected]> Closes #13208 from rxin/SPARK-14990. (cherry picked from commit 3ba34d4) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)