[SPARK-14783] [SPARK-14786] [BRANCH-1.6] Preserve full exception stacktrace in IsolatedClientLoader and Remove hive-cli dependency from hive subproject #12724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #57083 has finished for PR 12724 at commit
|
Contributor
Author
|
test this please |
|
Test build #57088 has finished for PR 12724 at commit
|
Contributor
Author
|
test this please |
|
Test build #57131 has finished for PR 12724 at commit
|
Contributor
Author
|
test this please |
|
Test build #2896 has finished for PR 12724 at commit
|
|
Test build #57145 has finished for PR 12724 at commit
|
|
Test build #57173 has finished for PR 12724 at commit
|
In IsolatedClientLoader, we have a`catch` block which throws an exception without wrapping the original exception, causing the full exception stacktrace and any nested exceptions to be lost. This patch fixes this, improving the usefulness of classloading error messages. Author: Josh Rosen <[email protected]> Closes #12548 from JoshRosen/improve-logging-for-hive-classloader-issues.
|
Test build #57193 has finished for PR 12724 at commit
|
Contributor
Author
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
|
Test build #57214 has finished for PR 12724 at commit
|
|
Test build #57221 has finished for PR 12724 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the branch-1.6 version of the following commits from @JoshRosen. We probably cannot change the dependency of sql/hive again. But, if anyone needs this, they can use this PR.
[SPARK-14783] Preserve full exception stacktrace in IsolatedClientLoader
In IsolatedClientLoader, we have a
catchblock which throws an exception without wrapping the original exception, causing the full exception stacktrace and any nested exceptions to be lost. This patch fixes this, improving the usefulness of classloading error messages.[SPARK-14786] Remove hive-cli dependency from hive subproject
The
hivesubproject currently depends onhive-cliin order to perform a check to see whether aSessionStateis an instance oforg.apache.hadoop.hive.cli.CliSessionState(see #9589). The introduction of thishive-clidependency has caused problems for users whose Hive metastore JAR classpaths don't include thehive-cliclasses (such as in #11495).This patch removes this dependency on
hive-cliand replaces theisInstanceOfcheck by reflection. I added a Maven Enforcer rule to banhive-clifrom thehivesubproject in order to make sure that this dependency is not accidentally reintroduced.