Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 27, 2016

What changes were proposed in this pull request?

This patch replaces most of the use of the runtime execution HiveConf with SQLConf instead.

How was this patch tested?

Updated existing tests to reflect the change.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57074 has finished for PR 12722 at commit 0e3111c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

To save your time, I hit the same errors. Want to share what I found. One test case called SQLConf.clear() and cleaned all the configurations. When we reloading the conf, we did not load the Hive-related configurations.

It might not be the best way to fix the issue. Below is what I changed. Hopefully, it helps you in this PR. Thanks!

1da261a

@rxin
Copy link
Contributor Author

rxin commented Apr 27, 2016

Thanks, @gatorsmile!

@rxin
Copy link
Contributor Author

rxin commented Apr 27, 2016

One thing is that I'm trying to get rid of the HiveConf, so I can't just apply your change directly.

@gatorsmile
Copy link
Member

I see. : )

@rxin
Copy link
Contributor Author

rxin commented Apr 27, 2016

OK I pushed a fix. Let's see if that works ...

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57085 has finished for PR 12722 at commit df35a93.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57098 has finished for PR 12722 at commit 48295c2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57095 has finished for PR 12722 at commit ff69e62.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57097 has finished for PR 12722 at commit e5de1f4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #2894 has finished for PR 12722 at commit 48295c2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 27, 2016

Test build #57186 has finished for PR 12722 at commit dad7095.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 28, 2016

Test build #57197 has finished for PR 12722 at commit d2470ce.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 29, 2016

Test build #2914 has finished for PR 12722 at commit d2470ce.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin rxin changed the title [SPARK-14941][SQL] Remove runtime HiveConf - WIP - NOT READY FOR REVIEW [SPARK-14941][SQL] Remove runtime HiveConf Apr 29, 2016
@rxin rxin closed this Apr 29, 2016
@rxin
Copy link
Contributor Author

rxin commented Apr 29, 2016

Closing this one as #12770 subsumes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants