[Minor] [ML] [PySpark] Fix omissive param setters which should use _set method #12531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #56363 has finished for PR 12531 at commit
|
Contributor
|
This keep slipping in somehow! I did a quick search and only found these two as well. LGTM, thanks! |
Contributor
|
@sethah I know the binary params here were added around the same time as your PR (a bit before I think). Hopefully these will be caught at PR stage in future :) |
Contributor
|
Merged to master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#11939 make Python param setters use the
_setmethod. This PR fix omissive ones.How was this patch tested?
Existing tests.
cc @jkbradley @sethah