[SPARK-14675][SQL] ClassFormatError when use Seq as Aggregator buffer type #12468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| // 1. CodegenFallback: it's children will not be used to generate code (call eval() instead) | ||
| // 2. ReferenceToExpressions: it's kind of an explicit sub-expression elimination. | ||
| val shouldRecurse = root match { | ||
| case _: CodegenFallback => false |
Contributor
There was a problem hiding this comment.
a few expressions implement CodegenFallback but only use it in some corner cases
|
Test build #56067 has finished for PR 12468 at commit
|
|
Test build #56163 has finished for PR 12468 at commit
|
| def declareMutableStates(): String = { | ||
| mutableStates.map { case (javaType, variableName, _) => | ||
| // It's possible that we add same mutable state twice, e.g. the `mergeExpressions` in | ||
| // `TypedAggregateExpression`, we should call `distinct` here to remove the duplicated ones. |
Contributor
There was a problem hiding this comment.
Can we avoid of adding the same mutable state twice?
Contributor
Author
There was a problem hiding this comment.
yea, we can transform the left deserializer in TypedAggregateExpression and create new LambdaVariable with different names. But I'm afraid there will be more similar problems so I go with this approach.
Contributor
|
LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #12067, we now use expressions to do the aggregation in
TypedAggregateExpression. To implement buffer merge, we produce a new buffer deserializer expression by replacingAttributeReferencewith right-side buffer attribute, like otherDeclarativeAggregates do, and finally combine the left and right buffer deserializer withInvoke.However, after #12338, we will add loop variable to class members when codegen
MapObjects. If theAggregatorbuffer type isSeq, which is implemented byMapObjectsexpression, we will add the same loop variable to class members twice(by left and right buffer deserializer), which cause theClassFormatError.This PR fixes this issue by calling
distinctbefore declare the class menbers.How was this patch tested?
new regression test in
DatasetAggregatorSuite