[Spark-14685] [CORE] Document heritability of localProperties #12455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rxin Documentation and tests PR. Enhancement PR to follow. |
marcintustin
changed the title
Contributor
Author
|
@JoshRosen This may well be of interest. As mentioned above, my enhancement PR is pending (running tests right now). |
|
Test build #2801 has finished for PR 12455 at commit
|
Contributor
Author
|
The test failures are probably bogus, as per http://mail-archives.apache.org/mod_mbox/spark-dev/201604.mbox/%3CCAMFhwAYRbN0yJGwzvrY8atzS9CCudzioF%3DbcGogCwPq3gPC6Uw%40mail.gmail.com%3E |
Contributor
Author
Contributor
|
Thanks - let's merge this first once Jenkins pass. |
|
Test build #2847 has finished for PR 12455 at commit
|
Contributor
Author
Contributor
|
Thanks - merging in master / branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 3, 2016
## What changes were proposed in this pull request? This updates the java-/scala- doc for setLocalProperty to document heritability of localProperties. This also adds tests for that behaviour. ## How was this patch tested? Tests pass. New tests were added. Author: Marcin Tustin <[email protected]> Closes #12455 from marcintustin/SPARK-14685. (cherry picked from commit 8028f3a) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This updates the java-/scala- doc for setLocalProperty to document heritability of localProperties. This also adds tests for that behaviour.
How was this patch tested?
Tests pass. New tests were added.