[Spark-14564] [ML] [MLlib] [PySpark] Python Word2Vec missing setWindowSize method #12428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyspark/ml/feature.py
Outdated
| "the minimum number of times a token must appear to be included in the " + | ||
| "word2vec model's vocabulary", typeConverter=TypeConverters.toInt) | ||
| windowSize = Param(Params._dummy(), "windowSize", | ||
| "the window size (context words from [-window, window])", |
Contributor
There was a problem hiding this comment.
Should mention the default value.
Contributor
|
Thanks for taking the initiative to do this. A few minor comments from the first pass through, but in the meantime maybe one the admins (possibly @jkbradley) could either say ok to jenkins to test or add to the whitelist? |
Contributor
|
ok to test |
python/pyspark/ml/tests.py
Outdated
|
|
||
| def test_word2vec_param(self): | ||
| model = Word2Vec() \ | ||
| .setWindowSize(6) |
Contributor
There was a problem hiding this comment.
minor, but this can be one line
Contributor
|
One minor comment. Pending that, the tests and @holdenk's comments, LGTM. |
Contributor
|
LGTM pending tests :) |
|
Test build #56080 has finished for PR 12428 at commit
|
Member
|
LGTM |
lw-lin
pushed a commit
to lw-lin/spark
that referenced
this pull request
Apr 20, 2016
…ze method ## What changes were proposed in this pull request? Added windowSize getter/setter to ML/MLlib ## How was this patch tested? Added test cases in tests.py under both ML and MLlib Author: Jason Lee <[email protected]> Closes apache#12428 from jasoncl/SPARK-14564.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added windowSize getter/setter to ML/MLlib
How was this patch tested?
Added test cases in tests.py under both ML and MLlib