[SPARK-14563] [ML] use a random table name instead of __THIS__ in SQLTransformer #12330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm |
|
Test build #55624 has finished for PR 12330 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2016
…ransformer ## What changes were proposed in this pull request? Use a random table name instead of `__THIS__` in SQLTransformer, and add a test for `transformSchema`. The problems of using `__THIS__` are: * It doesn't work under HiveContext (in Spark 1.6) * Race conditions ## How was this patch tested? * Manual test with HiveContext. * Added a unit test for `transformSchema` to improve coverage. cc: yhuai Author: Xiangrui Meng <[email protected]> Closes #12330 from mengxr/SPARK-14563. (cherry picked from commit 1995c2e) Signed-off-by: Xiangrui Meng <[email protected]>
Contributor
Author
|
Merged into master and branch-1.6. |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Apr 13, 2016
…ransformer ## What changes were proposed in this pull request? Use a random table name instead of `__THIS__` in SQLTransformer, and add a test for `transformSchema`. The problems of using `__THIS__` are: * It doesn't work under HiveContext (in Spark 1.6) * Race conditions ## How was this patch tested? * Manual test with HiveContext. * Added a unit test for `transformSchema` to improve coverage. cc: yhuai Author: Xiangrui Meng <[email protected]> Closes apache#12330 from mengxr/SPARK-14563. (cherry picked from commit 1995c2e) Signed-off-by: Xiangrui Meng <[email protected]> (cherry picked from commit 2554c35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use a random table name instead of
__THIS__in SQLTransformer, and add a test fortransformSchema. The problems of using__THIS__are:How was this patch tested?
transformSchemato improve coverage.cc: @yhuai