[SPARK-12566] [SPARK-14324] [ML] [WIP] GLM model family, link function support in SparkR:::glm #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55513 has finished for PR 12294 at commit
|
Contributor
There was a problem hiding this comment.
We can use rFormulaModel to avoid fitting again.
Contributor
|
LGTM except one place where we can avoid re-fitting. @yanboliang Could you create follow-up JIRAs so we can add the missing feature back? Thanks! |
Contributor
Author
|
@mengxr We already have SPARK-13925 to add summary statistics for SparkR glm. I will send a PR after this get in. |
|
Test build #55557 has finished for PR 12294 at commit
|
|
Test build #55605 has finished for PR 12294 at commit
|
Contributor
|
LGTM. Merged into master. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2016
…lumn ## What changes were proposed in this pull request? SparkR does not support type of vector which is the default type of feature column in ML. R predict also does not output intermediate feature column. So SparkR ```predict``` should not output feature column. In this PR, I only fix this issue for ```naiveBayes``` and ```survreg```. ```kmeans``` has the right code route already and ```glm``` will be fixed at SparkRWrapper refactor(#12294). ## How was this patch tested? No new tests. cc mengxr shivaram Author: Yanbo Liang <[email protected]> Closes #11958 from yanboliang/spark-14147.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
formula, family, data, epsilon and maxit.How was this patch tested?
Unit tests.
cc @mengxr @jkbradley @hhbyyh