[SPARK-14368][PySpark] Support python.spark.worker.memory with upper-case unit. #12163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case unit. This fix tries to address the issue in PySpark where `spark.python.worker.memory` could only be configured with a lower case unit (`k`, `m`, `g`, `t`). This fix allows the upper case unit (`K`, `M`, `G`, `T`) to be used as well. This is to conform to the JVM memory string as is specified in the documentation . This fix adds additional test to cover the changes.
Member
|
LGTM |
Member
|
Jenkins test this please |
|
Test build #54924 has finished for PR 12163 at commit
|
Member
|
retest this please. |
|
Test build #54935 has finished for PR 12163 at commit
|
Member
|
LGTM as well. Merging this into |
asfgit
pushed a commit
that referenced
this pull request
Apr 5, 2016
…case unit. ## What changes were proposed in this pull request? This fix tries to address the issue in PySpark where `spark.python.worker.memory` could only be configured with a lower case unit (`k`, `m`, `g`, `t`). This fix allows the upper case unit (`K`, `M`, `G`, `T`) to be used as well. This is to conform to the JVM memory string as is specified in the documentation . ## How was this patch tested? This fix adds additional test to cover the changes. Author: Yong Tang <[email protected]> Closes #12163 from yongtang/SPARK-14368. (cherry picked from commit 7db5624) Signed-off-by: Kousuke Saruta <[email protected]>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Apr 5, 2016
…case unit. ## What changes were proposed in this pull request? This fix tries to address the issue in PySpark where `spark.python.worker.memory` could only be configured with a lower case unit (`k`, `m`, `g`, `t`). This fix allows the upper case unit (`K`, `M`, `G`, `T`) to be used as well. This is to conform to the JVM memory string as is specified in the documentation . ## How was this patch tested? This fix adds additional test to cover the changes. Author: Yong Tang <[email protected]> Closes apache#12163 from yongtang/SPARK-14368. (cherry picked from commit 7db5624) Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 285cb9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fix tries to address the issue in PySpark where
spark.python.worker.memorycould only be configured with a lower case unit (
k,m,g,t). This fixallows the upper case unit (
K,M,G,T) to be used as well. This is toconform to the JVM memory string as is specified in the documentation .
How was this patch tested?
This fix adds additional test to cover the changes.