-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-14133][SQL] Throws exception for unsupported create/drop/alter index , and lock/unlock operations. #12069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-14133][SQL] Throws exception for unsupported create/drop/alter index , and lock/unlock operations. #12069
Conversation
|
This Jira also mentions alter table touch as an unsupported operation. But there is an explicit parser rule for this command , I was not sure if there is work in progress to support it or not ? If there are no plans to support I will update this PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a non-reserved keyword according to Hive? If it is please add it to the nonReserved rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is non-Reserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing the PR, Herman. Added it to the non-Reserved list.
|
@sureshthalamati thanks for working on this. The |
|
Test build #2709 has finished for PR 12069 at commit
|
|
Thanks for the input, Herman. Addressed the review comments , and fixed the test failure in my latest commit. |
|
@sureshthalamati can you rebase now? |
e3559ec to
31ae9d5
Compare
|
Thanks for reviewing the PR , Andrew. I rebased it. |
|
retest this please |
|
Test build #54655 has finished for PR 12069 at commit
|
|
The failed test in previous run : org.apache.spark.sql.sources.JsonHadoopFsRelationSuite passes for me on my local machine. |
|
Yeah that is a bit funny. I triggered another build. |
|
Test build #2719 has finished for PR 12069 at commit
|
|
LGTM |
|
Merging to master. Thanks! |
|
Thanks, Herman. |
What changes were proposed in this pull request?
This PR throws Unsupported Operation exception for create index, drop index, alter index , lock table , lock database, unlock table, and unlock database operations that are not supported in Spark SQL. Currently these operations are executed executed by Hive.
Error:
spark-sql> drop index my_index on my_table;
Error in query:
Unsupported operation: drop index(line 1, pos 0)
How was this patch tested?
Added test cases to HiveQuerySuite
@yhuai @hvanhovell @andrewor14