[SPARK-14225][SQL] Cap the length of toCommentSafeString at 128 chars #12022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @davies |
Contributor
Author
|
Going to close this and let @sameeragarwal take over. |
|
Test build #54399 has finished for PR 12022 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Mar 29, 2016
## What changes were proposed in this pull request? Builds on #12022 and (a) appends "..." to truncated comment strings and (b) fixes indentation in lines after the commented strings if they happen to have a `(`, `{`, `)` or `}` ## How was this patch tested? Manually examined the generated code. Author: Sameer Agarwal <[email protected]> Closes #12044 from sameeragarwal/comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I just saw a query with over 1000 fields and the generated expression comment is pages long. At that level printing them no longer gives us much benefit. We should just cap the length at some level. This patch changes it to max 128 chars.
How was this patch tested?
Manually examined the generated code.