[SPARK-14135] Add off-heap storage memory bookkeeping support to MemoryManager #11942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #54074 has finished for PR 11942 at commit
|
|
Test build #54077 has finished for PR 11942 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #54080 has finished for PR 11942 at commit
|
|
Test build #54196 has finished for PR 11942 at commit
|
|
Test build #54201 has finished for PR 11942 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #54204 has finished for PR 11942 at commit
|
Contributor
Author
|
/cc @andrewor14 @nongli @rxin, could one of you review this to unblock the off-heap patch? |
|
Test build #54223 has finished for PR 11942 at commit
|
Contributor
|
LGTM |
|
Test build #2698 has finished for PR 11942 at commit
|
Contributor
|
Merging in master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends Spark's
UnifiedMemoryManagerto add bookkeeping support for off-heap storage memory, an requirement for enabling off-heap caching (which will be done by #11805). TheMemoryManager'sstorageMemoryPoolhas been split into separate on- and off-heap pools and the storage and unroll memory allocation methods have been updated to accept amemoryModeparameter to specify whether allocations should be performed on- or off-heap.In order to reduce the testing surface, the
StaticMemoryManagerdoes not support off-heap caching (we plan to eventually remove theStaticMemoryManager, so this isn't a significant limitation).