Skip to content

SPARK-1316. Remove use of Commons IO #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

SPARK-1316. Remove use of Commons IO #1173

wants to merge 2 commits into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jun 21, 2014

Commons IO is actually barely used, and is not a declared dependency. This just replaces with equivalents from the JDK and Guava.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16001/

rxin
rxin reviewed Jun 22, 2014
View reviewed changes
core/src/test/scala/org/apache/spark/util/FileAppenderSuite.scala Outdated
Copy link
Contributor

@rxin rxin Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mind moving this to before org.apache.spark?

@pwendell
Copy link
Contributor

pwendell commented Jun 22, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16006/

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16011/

@rxin
Copy link
Contributor

rxin commented Jun 22, 2014

Thanks. I've merged this in master.

@asfgit asfgit closed this in 9fe28c3 Jun 22, 2014
@srowen srowen deleted the SPARK-1316 branch June 23, 2014 06:25
cloud-fan
cloud-fan reviewed Jun 23, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala
Copy link
Contributor

@cloud-fan cloud-fan Jun 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using java.nio.file.Files.move(Path source, Path target, CopyOption... options)? Does com.google.common.io.Files have better performance than the built-in Files in jdk?

Copy link
Member Author

@srowen srowen Jun 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's because it doesn't exist in Java 6 :) http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html

pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@srowen @pdeyhim
SPARK-1316. Remove use of Commons IO
a50e69d 
Commons IO is actually barely used, and is not a declared dependency. This just replaces with equivalents from the JDK and Guava.

Author: Sean Owen <[email protected]>

Closes apache#1173 from srowen/SPARK-1316 and squashes the following commits:

2eb53db [Sean Owen] Reorder Guava import
8fde404 [Sean Owen] Remove use of Commons IO, which is not actually a dependency
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@srowen @conviva-zz
SPARK-1316. Remove use of Commons IO
e010ce8 
Commons IO is actually barely used, and is not a declared dependency. This just replaces with equivalents from the JDK and Guava.

Author: Sean Owen <[email protected]>

Closes apache#1173 from srowen/SPARK-1316 and squashes the following commits:

2eb53db [Sean Owen] Reorder Guava import
8fde404 [Sean Owen] Remove use of Commons IO, which is not actually a dependency
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
@ekrivokonmapr
[EZAF-4397] Spark 3.5.0 Kafka Streaming job fails (apache#1173)
10bcf29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srowen @AmplabJenkins @pwendell @rxin @cloud-fan