[SPARK-9837] [ML] R-like summary statistics for GLMs via iteratively reweighted least squares #11694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53066 has finished for PR 11694 at commit
|
|
Test build #53067 has finished for PR 11694 at commit
|
|
|
||
| new IterativelyReweightedLeastSquaresModel(model.coefficients, model.intercept) | ||
| new IterativelyReweightedLeastSquaresModel(model.coefficients, | ||
| model.intercept, model.diagInvAtWA, iter) |
Contributor
There was a problem hiding this comment.
new IterativelyReweightedLeastSquaresModel(
model.coefficients, model.intercept, model.diagInvAtWA, iter)
Contributor
|
I made one pass and left some minor comments line. This looks great overall! |
|
Test build #53269 has finished for PR 11694 at commit
|
Contributor
|
LGTM. Merged into master. Thanks! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…eweighted least squares ## What changes were proposed in this pull request? Provide R-like summary statistics for GLMs via iteratively reweighted least squares. ## How was this patch tested? unit tests. Author: Yanbo Liang <[email protected]> Closes apache#11694 from yanboliang/spark-9837.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide R-like summary statistics for GLMs via iteratively reweighted least squares.
How was this patch tested?
unit tests.