Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jun 20, 2014

@willb
Copy link
Contributor

willb commented Jun 20, 2014

LGTM; this is basically exactly what I did (willb@b272f6b), except you also added a test. (I replied quickly because I reran the Hive tests with my version of this change and so I assume yours will pass as well.)

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15965/

@rxin
Copy link
Contributor Author

rxin commented Jun 20, 2014

Ok merging this in master & branch-1.0.

asfgit pushed a commit that referenced this pull request Jun 20, 2014
@willb

Author: Reynold Xin <[email protected]>

Closes #1161 from rxin/having-filter and squashes the following commits:

fa8359a [Reynold Xin] [SPARK-2225] Turn HAVING without GROUP BY into WHERE.

(cherry picked from commit 0ac71d1)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 0ac71d1 Jun 20, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@willb

Author: Reynold Xin <[email protected]>

Closes apache#1161 from rxin/having-filter and squashes the following commits:

fa8359a [Reynold Xin] [SPARK-2225] Turn HAVING without GROUP BY into WHERE.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@willb

Author: Reynold Xin <[email protected]>

Closes apache#1161 from rxin/having-filter and squashes the following commits:

fa8359a [Reynold Xin] [SPARK-2225] Turn HAVING without GROUP BY into WHERE.
wangyum pushed a commit that referenced this pull request May 26, 2023
* [CARMEL-6383] Allow introduce new shuffle in skew handling

* fix code style

* Support multi skew joins in EliminateSkewOptimzeIntroducedShuffle

* fix ut

* fix ut

* Add tag to detect newly introduced shuffle

* Add tags back when updateShuffleReads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants