Skip to content

Conversation

@jerry86
Copy link

@jerry86 jerry86 commented Jun 20, 2014

Fixed a problem in previous file in which some information regarding AWS instance types were wrong. Such information was updated base upon current AWS EC2 data.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@pwendell
Copy link
Contributor

According to the table, it seems like all of the types you changed support both hvm and pvm?

@jerry86
Copy link
Author

jerry86 commented Jun 20, 2014

Yes. But pvm has better performance than hvm.

PS, hvm AMIs seem to have problems working along with Apache modules.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15966/

@pwendell
Copy link
Contributor

Okay - I think we should merge this into master and then backport it into branch-1.0. Except in the backport I'm not going to change the existing instance types from hvm-to-pvm, this could cause problems for users who are relying on the existing behavior.

@asfgit asfgit closed this in 62d4a0f Jun 26, 2014
asfgit pushed a commit that referenced this pull request Jun 26, 2014
Fixed a problem in previous file in which some information regarding AWS instance types were wrong. Such information was updated base upon current AWS EC2 data.

Author: Zichuan Ye <[email protected]>

Closes #1156 from jerry86/master and squashes the following commits:

ff36e95 [Zichuan Ye] Fixing AWS instance type information based upon current EC2 data
(cherry picked from commit 62d4a0f)

Conflicts:

	ec2/spark_ec2.py
@pwendell
Copy link
Contributor

pwendell commented Sep 3, 2014

@jerry86 actually it turns out PVM had some performance issues for PySpark that caused a regression during the 1.1 release testing. So I think we'll stick with HVM for at least some of these.

pwendell added a commit to pwendell/spark that referenced this pull request Sep 3, 2014
During regression tests of Spark 1.1 we discovered perf issues with
PVM instances when running PySpark. This reverts a change added in apache#1156
which changed the default type for m3 instances to PVM.
asfgit pushed a commit that referenced this pull request Sep 3, 2014
During regression tests of Spark 1.1 we discovered perf issues with
PVM instances when running PySpark. This reverts a change added in #1156
which changed the default type for m3 instances to PVM.

Author: Patrick Wendell <[email protected]>

Closes #2244 from pwendell/ec2-hvm and squashes the following commits:

1342d7e [Patrick Wendell] SPARK-3358: [EC2] Switch back to HVM instances for m3.X.
asfgit pushed a commit that referenced this pull request Sep 3, 2014
During regression tests of Spark 1.1 we discovered perf issues with
PVM instances when running PySpark. This reverts a change added in #1156
which changed the default type for m3 instances to PVM.

Author: Patrick Wendell <[email protected]>

Closes #2244 from pwendell/ec2-hvm and squashes the following commits:

1342d7e [Patrick Wendell] SPARK-3358: [EC2] Switch back to HVM instances for m3.X.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Fixed a problem in previous file in which some information regarding AWS instance types were wrong. Such information was updated base upon current AWS EC2 data.

Author: Zichuan Ye <[email protected]>

Closes apache#1156 from jerry86/master and squashes the following commits:

ff36e95 [Zichuan Ye] Fixing AWS instance type information based upon current EC2 data
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
During regression tests of Spark 1.1 we discovered perf issues with
PVM instances when running PySpark. This reverts a change added in apache#1156
which changed the default type for m3 instances to PVM.

Author: Patrick Wendell <[email protected]>

Closes apache#2244 from pwendell/ec2-hvm and squashes the following commits:

1342d7e [Patrick Wendell] SPARK-3358: [EC2] Switch back to HVM instances for m3.X.
@jerry86
Copy link
Author

jerry86 commented Sep 4, 2014

@pwendell I think this seems to be the best choice at this moment. Not sure if Amazon has made or will make any improvements to PVM that fits PySpark.

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants