[SPARK-13694][SQL] QueryPlan.expressions should always include all expressions #11532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52500 has finished for PR 11532 at commit
|
Contributor
|
LGTM |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…pressions ## What changes were proposed in this pull request? It's weird that expressions don't always have all the expressions in it. This PR marks `QueryPlan.expressions` final to forbid sub classes overriding it to exclude some expressions. Currently only `Generate` override it, we can use `producedAttributes` to fix the unresolved attribute problem for it. Note that this PR doesn't fix the problem in apache#11497 ## How was this patch tested? existing tests. Author: Wenchen Fan <[email protected]> Closes apache#11532 from cloud-fan/generate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's weird that expressions don't always have all the expressions in it. This PR marks
QueryPlan.expressionsfinal to forbid sub classes overriding it to exclude some expressions. Currently onlyGenerateoverride it, we can useproducedAttributesto fix the unresolved attribute problem for it.Note that this PR doesn't fix the problem in #11497
How was this patch tested?
existing tests.