[SPARK-13632] [SQL] Move commands.scala to command package #11482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think you possibly gave a wrong link by mistake. I don't see any relation between this PR and #11408 (or am I missing something?) |
|
Test build #52354 has finished for PR 11482 at commit
|
Contributor
|
LGTM - @andrewor14 please update the pr description to fix the link to the pr, before you merge. |
Contributor
Author
|
Oops, I fixed the description. |
Conflicts: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
|
Test build #52408 has finished for PR 11482 at commit
|
Contributor
|
Merging in master. |
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2016
## What changes were proposed in this pull request? This patch simply moves things to existing package `o.a.s.sql.catalyst.parser` in an effort to reduce the size of the diff in #11048. This is conceptually the same as a recently merged patch #11482. ## How was this patch tested? Jenkins. Author: Andrew Or <[email protected]> Closes #11506 from andrewor14/parser-package.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This patch simply moves things to a new package in an effort to reduce the size of the diff in apache#11048. Currently the new package only has one file, but in the future we'll add many new commands in SPARK-13139. ## How was this patch tested? Jenkins. Author: Andrew Or <[email protected]> Closes apache#11482 from andrewor14/commands-package.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This patch simply moves things to existing package `o.a.s.sql.catalyst.parser` in an effort to reduce the size of the diff in apache#11048. This is conceptually the same as a recently merged patch apache#11482. ## How was this patch tested? Jenkins. Author: Andrew Or <[email protected]> Closes apache#11506 from andrewor14/parser-package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch simply moves things to a new package in an effort to reduce the size of the diff in #11048. Currently the new package only has one file, but in the future we'll add many new commands in SPARK-13139.
How was this patch tested?
Jenkins.