Skip to content

Conversation

@tsudukim
Copy link
Contributor

@tsudukim tsudukim commented Mar 1, 2016

What changes were proposed in this pull request?

This patch fixes the problem that pyspark fails on Windows because pyspark can't find spark-submit2.cmd.

How was this patch tested?

manual tests:
I ran bin\pyspark.cmd and checked if pyspark is launched correctly after this patch is applyed.

@srowen
Copy link
Member

srowen commented Mar 1, 2016

Good catch. This is really like a follow-on to your SPARK-3943 from a long time ago

@SparkQA
Copy link

SparkQA commented Mar 1, 2016

Test build #52231 has finished for PR 11442 at commit 5a8ea5b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 12a2a57 Mar 1, 2016
@srowen
Copy link
Member

srowen commented Mar 1, 2016

Merged to master. Actually, this was not a problem in earlier branches, and I figured out that 2ba9b6a#diff-fbd7428b349a0b32fcc71e6ea4eb5d98 actually inadvertently reverted the change that your PR restores now. It could well be my fault, messing up a merge somewhere.

@tsudukim
Copy link
Contributor Author

tsudukim commented Mar 2, 2016

Thanks!

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

This patch fixes the problem that pyspark fails on Windows because pyspark can't find ```spark-submit2.cmd```.

## How was this patch tested?

manual tests:
  I ran ```bin\pyspark.cmd``` and checked if pyspark is launched correctly after this patch is applyed.

Author: Masayoshi TSUZUKI <[email protected]>

Closes apache#11442 from tsudukim/feature/SPARK-13592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants