Skip to content

[SPARK-2209][SQL] Cast shouldn't do null check twice. #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-2209][SQL] Cast shouldn't do null check twice. #1143

wants to merge 2 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jun 20, 2014

Also took the chance to clean up cast a little bit. Too many arrows on each line before!

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15937/

liancheng
liancheng reviewed Jun 20, 2014
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala Outdated
Copy link
Contributor

@liancheng liancheng Jun 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about merging these two if statements into 1 with &&?

@liancheng
Copy link
Contributor

liancheng commented Jun 20, 2014

LGTM. Making everything other than eval to be private[this] makes sense, so that eval is guaranteed to be the only entrance of type casting and the null check won't be skipped.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15941/

@rxin
Copy link
Contributor Author

rxin commented Jun 20, 2014

Ok merging this in master & branch-1.0.

@asfgit asfgit closed this in c55bbb4 Jun 20, 2014
asfgit pushed a commit that referenced this pull request Jun 20, 2014
@rxin
[SPARK-2209][SQL] Cast shouldn't do null check twice.
86c4f5a 
Also took the chance to clean up cast a little bit. Too many arrows on each line before!

Author: Reynold Xin <[email protected]>

Closes #1143 from rxin/cast and squashes the following commits:

dd006cb [Reynold Xin] Code review feedback.
c2b88ae [Reynold Xin] [SPARK-2209][SQL] Cast shouldn't do null check twice.

(cherry picked from commit c55bbb4)
Signed-off-by: Reynold Xin <[email protected]>
@rxin rxin deleted the cast branch June 20, 2014 07:01
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@rxin @pdeyhim
[SPARK-2209][SQL] Cast shouldn't do null check twice.
39693e1 
Also took the chance to clean up cast a little bit. Too many arrows on each line before!

Author: Reynold Xin <[email protected]>

Closes apache#1143 from rxin/cast and squashes the following commits:

dd006cb [Reynold Xin] Code review feedback.
c2b88ae [Reynold Xin] [SPARK-2209][SQL] Cast shouldn't do null check twice.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin @conviva-zz
[SPARK-2209][SQL] Cast shouldn't do null check twice.
ecdaba3 
Also took the chance to clean up cast a little bit. Too many arrows on each line before!

Author: Reynold Xin <[email protected]>

Closes apache#1143 from rxin/cast and squashes the following commits:

dd006cb [Reynold Xin] Code review feedback.
c2b88ae [Reynold Xin] [SPARK-2209][SQL] Cast shouldn't do null check twice.
wangyum pushed a commit that referenced this pull request May 26, 2023
Revert "[CARMEL-6365] Don't store data in quota free folder when crea…
d1c2c3a 
…te temp … (#1126)" (#1143)

This reverts commit c6c737d.
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
@ekrivokonmapr
MapR [SPARK-1220] Reported vulnerabilities in MEP 6.3.0 in mapr-spark…
310ca51 
…-2.4.4 (apache#1143)

Co-authored-by: Egor Krivokon <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @AmplabJenkins @liancheng