Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

JIRA: https://issues.apache.org/jira/browse/SPARK-13550

What changes were proposed in this pull request?

Just add a java example for ml.clustering.BisectingKMeans

How was this patch tested?

manual tests were done.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@srowen
Copy link
Member

srowen commented Feb 29, 2016

I'm not sure we need an example for every single algorithm, unless an example meaningfully explains non-trivial usage that others don't. We already have examples for k-means; does this add much?

@zhengruifeng
Copy link
Contributor Author

@srowen this is the first java example for ml.clustering.BisectingKMeans

@mengxr
Copy link
Contributor

mengxr commented Mar 1, 2016

@srowen It would be nice to have example code in the user guide for every algorithm. And this PR helps.

@mengxr
Copy link
Contributor

mengxr commented Mar 1, 2016

ok to test

@SparkQA
Copy link

SparkQA commented Mar 1, 2016

Test build #52220 has finished for PR 11428 at commit 4f0e3b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class JavaBisectingKMeansExample

@mengxr
Copy link
Contributor

mengxr commented Mar 1, 2016

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in 3c5f5e3 Mar 1, 2016
@zhengruifeng zhengruifeng deleted the ml_bkm_je branch March 1, 2016 07:57
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
JIRA: https://issues.apache.org/jira/browse/SPARK-13550

## What changes were proposed in this pull request?

Just add a java example for ml.clustering.BisectingKMeans

## How was this patch tested?

manual tests were done.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Author: Zheng RuiFeng <[email protected]>

Closes apache#11428 from zhengruifeng/ml_bkm_je.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants