[SPARK-13519][Core]Driver should tell Executor to stop itself when cleaning executor's state #11399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case RemoveExecutor(executorId, reason) => | ||
| // We will remove the executor's state and cannot restore it. However, the connection | ||
| // between the driver and the executor may be still alive so that the executor won't exit | ||
| // automatically (E.g., Master will send RemoveExecutor when a work is lost but the executor |
Contributor
There was a problem hiding this comment.
this is the general class so I don't think we should mention standalone-mode specific things
|
Test build #52074 has finished for PR 11399 at commit
|
|
Test build #52072 has finished for PR 11399 at commit
|
|
Test build #52075 has finished for PR 11399 at commit
|
|
Test build #52077 has finished for PR 11399 at commit
|
Contributor
|
Merged into master. I'm a bit hesitant to backport this into 1.6 because it may change behavior in a way that we did not anticipate. If there is interest to backport we should discuss more. |
asfgit
pushed a commit
that referenced
this pull request
May 11, 2016
…leaning executor's state ## What changes were proposed in this pull request? When the driver removes an executor's state, the connection between the driver and the executor may be still alive so that the executor cannot exit automatically (E.g., Master will send RemoveExecutor when a work is lost but the executor is still alive), so the driver should try to tell the executor to stop itself. Otherwise, we will leak an executor. This PR modified the driver to send `StopExecutor` to the executor when it's removed. ## How was this patch tested? manual test: increase the worker heartbeat interval to force it's always timeout and the leak executors are gone. Author: Shixiong Zhu <[email protected]> Closes #11399 from zsxwing/SPARK-13519.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 12, 2016
…leaning executor's state ## What changes were proposed in this pull request? When the driver removes an executor's state, the connection between the driver and the executor may be still alive so that the executor cannot exit automatically (E.g., Master will send RemoveExecutor when a work is lost but the executor is still alive), so the driver should try to tell the executor to stop itself. Otherwise, we will leak an executor. This PR modified the driver to send `StopExecutor` to the executor when it's removed. ## How was this patch tested? manual test: increase the worker heartbeat interval to force it's always timeout and the leak executors are gone. Author: Shixiong Zhu <[email protected]> Closes apache#11399 from zsxwing/SPARK-13519. (cherry picked from commit c433c0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the driver removes an executor's state, the connection between the driver and the executor may be still alive so that the executor cannot exit automatically (E.g., Master will send RemoveExecutor when a work is lost but the executor is still alive), so the driver should try to tell the executor to stop itself. Otherwise, we will leak an executor.
This PR modified the driver to send
StopExecutorto the executor when it's removed.How was this patch tested?
manual test: increase the worker heartbeat interval to force it's always timeout and the leak executors are gone.