Skip to content

Conversation

@movelikeriver
Copy link
Contributor

Refine naive Bayes example by checking model after loading it.
This is Java version, to be consistent with Python version in #11125

*/

/*
* Usage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this usage text probably isn't the format we want, its pretty specific to each Spark release. Maybe look at some of the other files in this directory and see how they do their usage?

@holdenk
Copy link
Contributor

holdenk commented Apr 28, 2016

Thanks for taking on this issue & fixing it across multiple languages.

A super minor thing is generally we try and have separate JIRAs for separate PRs - so in this case creating a sub task on the initial PR to also update Scala might be better from a tracking point of view (since when I went to look at this PR my first thought was that the issue had already been resolved).

You might also want to try running the scala linter locally on your code (e.g. ./dev/lint-scala) and make sure it conforms to the style rules.

@HyukjinKwon
Copy link
Member

Hi @movelikeriver, are you able to proceed this further? If not, maybe it'd be better closed for now.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants