Skip to content

Conversation

@dorx
Copy link
Contributor

@dorx dorx commented Jun 18, 2014

Some IDEs don’t support unicode characters in source code. Check if this breaks binary compatibility.

Some IDEs don’t support unicode characters in source code
@dorx
Copy link
Contributor Author

dorx commented Jun 18, 2014

@ash211 @rxin @mengxr

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@rxin
Copy link
Contributor

rxin commented Jun 18, 2014

@ash211 ...

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15882/

@ash211
Copy link
Contributor

ash211 commented Jun 18, 2014

That even works in Scala? I definitely didn't intend to commit that as a single Unicode character as opposed to two characters -- an '=' and a '>' and code in Vim which I wouldn't expect to do character replacement, but who knows.

Definitely replace it with =>

+1 LGTM

@rxin
Copy link
Contributor

rxin commented Jun 18, 2014

Thanks. I've merged this.

@asfgit asfgit closed this in 45a95f8 Jun 18, 2014
@dorx
Copy link
Contributor Author

dorx commented Jun 18, 2014

@ash211 FWIW they have other unicode operators supported in addition to ⇒: http://www.scala-lang.org/old/node/4723
Might want to look into adding a no-unicode-char rule in scalastyle.

@ash211
Copy link
Contributor

ash211 commented Jun 18, 2014

Agreed, I'll file a ticket about it

On Wed, Jun 18, 2014 at 6:07 PM, dorx [email protected] wrote:

@ash211 https://github.com/ash211 FWIW they have other unicode
operators supported in addition to ⇒:
http://www.scala-lang.org/old/node/4723
Might want to look into adding a no-unicode-char rule in scalastyle.


Reply to this email directly or view it on GitHub
#1119 (comment).

@ash211
Copy link
Contributor

ash211 commented Jun 18, 2014

Dorx, can you add what IDE that was to the below ticket? Thanks!

https://issues.apache.org/jira/browse/SPARK-2182

On Wed, Jun 18, 2014 at 6:18 PM, Andrew Ash [email protected] wrote:

Agreed, I'll file a ticket about it

On Wed, Jun 18, 2014 at 6:07 PM, dorx [email protected] wrote:

@ash211 https://github.com/ash211 FWIW they have other unicode
operators supported in addition to ⇒:
http://www.scala-lang.org/old/node/4723
Might want to look into adding a no-unicode-char rule in scalastyle.


Reply to this email directly or view it on GitHub
#1119 (comment).

pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
Some IDEs don’t support unicode characters in source code. Check if this breaks binary compatibility.

Author: Doris Xin <[email protected]>

Closes apache#1119 from dorx/unicode and squashes the following commits:

05618c3 [Doris Xin] Remove unicode operator from RDD.scala
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Some IDEs don’t support unicode characters in source code. Check if this breaks binary compatibility.

Author: Doris Xin <[email protected]>

Closes apache#1119 from dorx/unicode and squashes the following commits:

05618c3 [Doris Xin] Remove unicode operator from RDD.scala
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants