Skip to content

Conversation

@hvanhovell
Copy link
Contributor

The SparkSqlLexer currently swallows characters which have not been defined in the grammar. This causes problems with SQL commands, such as: add jar file:///tmp/a@b/TestUDTF.jar. In this example the @ is swallowed.

This PR adds an extra Lexer rule to handle such input, and makes a tiny modification to the ASTNode.

cc @davies @liancheng

@davies
Copy link
Contributor

davies commented Feb 3, 2016

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add test cases where the remainder part contains whitespace characters?

@liancheng
Copy link
Contributor

This PR probably also fixes SPARK-13150, which is about flaky tests caused by the @ removal bug.

@SparkQA
Copy link

SparkQA commented Feb 3, 2016

Test build #50664 has finished for PR 11052 at commit 5a275ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 3, 2016

Test build #50665 has finished for PR 11052 at commit 3b1e475.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 3, 2016

Test build #2510 has finished for PR 11052 at commit c08a842.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Feb 3, 2016

Merging this into master, thanks!

@asfgit asfgit closed this in 9dd2741 Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants