Skip to content

[SPARK-12868] - ADD JAR via sparkSQL JDBC will fail when using a HDFS… #11026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-12868] - ADD JAR via sparkSQL JDBC will fail when using a HDFS… #11026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab1b92
[SPARK-12868] - ADD JAR via sparkSQL JDBC will fail when using a HDFS…
Feb 2, 2016
4dc5258
Added a test for testing add jar with a HDFS URI
Feb 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ package org.apache.spark.sql.hive.client

import java.io.{File, PrintStream}
import java.util.{Map => JMap}
import java.net.URL

import scala.collection.JavaConverters._
import scala.language.reflectiveCalls

import org.apache.hadoop.fs.FsUrlStreamHandlerFactory
import org.apache.hadoop.fs.Path
import org.apache.hadoop.hive.conf.HiveConf
import org.apache.hadoop.hive.metastore.api.{Database, FieldSchema}
Expand Down Expand Up @@ -569,6 +571,12 @@ private[hive] class ClientWrapper(
}

def addJar(path: String): Unit = {
try {
URL.setURLStreamHandlerFactory(new FsUrlStreamHandlerFactory);
} catch {
// Factory can only be set once per JVM
case e: java.lang.Error if e.getMessage contains "factory already defined" => logDebug("Factory already define", e)
}
val uri = new Path(path).toUri
val jarURL = if (uri.getScheme == null) {
// `path` is a local file path without a URL scheme
Expand Down
10 changes: 10 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,16 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
sql("DROP TABLE t1")
}

test("SPARK-12868 ADD JAR FROM HDFS") {
val testJar = "hdfs://nn1:8020/foo.jar"
// This should fail with unknown host, as its just testing the URL parsing
// before SPARK-12868 it was failing with Malformed URI
val e = intercept[RuntimeException] {
sql(s"ADD JAR $testJar")
}
assert(e.getMessage.contains("java.net.UnknownHostException: nn1"))
}

test("CREATE TEMPORARY FUNCTION") {
val funcJar = TestHive.getHiveFile("TestUDTF.jar").getCanonicalPath
val jarURL = s"file://$funcJar"
Expand Down