Skip to content

Conversation

@HyukjinKwon
Copy link
Member

https://issues.apache.org/jira/browse/SPARK-13137

This PR adds a filter in schema inference so that it does not emit NullPointException.

Also, I removed MAX_COMMENT_LINES_IN_HEADERbut instead used a monad chaining with filter() and first().

Lastly, I simply added a newline rather than adding a new file for this so that this is covered with the original tests.

@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50563 has finished for PR 11023 at commit 5214e8a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50564 has finished for PR 11023 at commit 5214e8a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@falaki
Copy link
Contributor

falaki commented Feb 17, 2016

Thanks @HyukjinKwon this looks good to me.

@HyukjinKwon
Copy link
Member Author

cc @rxin

@rxin
Copy link
Contributor

rxin commented Feb 21, 2016

Thanks. Merging in master.

@asfgit asfgit closed this in 7eb83fe Feb 21, 2016
@HyukjinKwon HyukjinKwon deleted the SPARK-13137 branch September 23, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants