-
Notifications
You must be signed in to change notification settings - Fork 28.9k
SPARK-2158 Clean up core/stdout file from FileAppenderSuite #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15829/ |
|
jenkins, test this please |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15840/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, this was mistake on my part. My original intention was to use testFile at the top of this file, similar to the other test suites. I goofed up. Its best to use that, as it will get automatically take care of by the after { }
|
One small comment, otherwise LGTM. Thanks for catching this! |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
@tdas Author: Mark Hamstra <[email protected]> Closes apache#1100 from markhamstra/SPARK-2158 and squashes the following commits: ae8e069 [Mark Hamstra] Response to TD's review 2f1e201 [Mark Hamstra] Cleanup 'stdout' file within FileAppenderSuite
@tdas Author: Mark Hamstra <[email protected]> Closes apache#1100 from markhamstra/SPARK-2158 and squashes the following commits: ae8e069 [Mark Hamstra] Response to TD's review 2f1e201 [Mark Hamstra] Cleanup 'stdout' file within FileAppenderSuite
* add multi-scheme auth handler able to support multiple authentication schemes at the same time * add clone of mapr 'BasicAuthHander' classes * add primitive implementation of JWT auth handler
@tdas